Skip to content

Conversation

lumynou5
Copy link
Contributor

@lumynou5 lumynou5 commented Mar 5, 2025

The commit e0c6b11 unintentionally deleted the assignment to 'safe' in dummy 'list_for_each_entry_safe', so the originally suppressed reports of uninitialized variables were no longer suppressed.

Closes: #229

Change-Id: Ibfe2a44e425c810b8e0b12bc44b42e6398b3b23c

jserv

This comment was marked as duplicate.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mention See: commit e0c6b11 at the end of git commit messages. Instead, express what this commit affected.

@lumynou5
Copy link
Contributor Author

lumynou5 commented Mar 6, 2025

Don't mention See: commit e0c6b11 at the end of git commit messages.

I thought we should mention what "the previous fix" is?

@lumynou5
Copy link
Contributor Author

lumynou5 commented Mar 6, 2025

I re-edited the commit message:

The commit e0c6b11 unintentionally deleted the assignment to 'safe' in dummy 'list_for_each_entry_safe', so the originally suppressed reports of uninitialized variables were no longer suppressed.

Closes: #229

Is this better? I'm not sure how to describe the change and its reason well, if the message has any flaw, please guide me.

@jserv
Copy link
Contributor

jserv commented Mar 6, 2025

Is this better?

Yes, please amend the message.

The commit e0c6b11 unintentionally
deleted the assignment to 'safe' in dummy 'list_for_each_entry_safe', so
the originally suppressed reports of uninitialized variables were no
longer suppressed.

Closes: sysprog21#229

Change-Id: Ibfe2a44e425c810b8e0b12bc44b42e6398b3b23c
@lumynou5 lumynou5 changed the title Fix dummy list_for_each_entry_safe Fix dummy 'list_for_each_entry_safe' Mar 6, 2025
@jserv jserv merged commit 122aea9 into sysprog21:master Mar 6, 2025
1 of 2 checks passed
@jserv
Copy link
Contributor

jserv commented Mar 6, 2025

Thank @lumynou5 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cppcheck: Uninitialized variable warning
2 participants